Add Recordable implementation for otprotocol exporter#49
Conversation
…try-cpp into recorder-interface
rnburn
requested review from
g-easy,
jmacd,
maxgolov,
reyang and
tigrannajaryan
as code owners
| @@ -0,0 +1,28 @@ | |||
| #include "src/exporter/otprotocol/recordable.h" | |||
|
|
|||
| OPENTELEMETRY_BEGIN_NAMESPACE | |||
There was a problem hiding this comment.
Should exporters live in the internal namespace?
There was a problem hiding this comment.
I separated out into an exporters folder, similar to how it's done for go and java.
| - run: ./ci/install_bazelisk.sh | ||
| - run: ./ci/install_gcc48.sh | ||
| - run: CC=/usr/bin/g++-4.8 ./ci/do_ci.sh bazel.test | ||
| - run: CC=/usr/bin/g++-4.8 ./ci/do_ci.sh bazel.test_api |
There was a problem hiding this comment.
API is gcc 4.8 compatible but SDK is not?
There was a problem hiding this comment.
protobuf can't work with gcc-4.8.
Maybe I should exclude just some portions of the sdk from legacy compiler tests?
There was a problem hiding this comment.
Up to you. Sorry to hear about protobuf.
| @@ -0,0 +1,33 @@ | |||
| #pragma once | |||
|
|
|||
| #include "src/trace/recordable.h" | |||
There was a problem hiding this comment.
I think headers needed to implement exporters should be placed in sdk/include. However, this can be done in a different PR.
There was a problem hiding this comment.
Moved Recodable into the headers folder.
[SDK] Added reserve for spans array in BatchSpanProcessor. (open-telemetry#2724)
3 participants
No description provided.