[API] Comply with W3C Trace Context#3115
Merged
marcalff merged 34 commits intoopen-telemetry:mainfrom Nov 6, 2024
Merged
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3115 +/- ##
==========================================
+ Coverage 87.12% 87.83% +0.72%
==========================================
Files 200 195 -5
Lines 6109 6138 +29
==========================================
+ Hits 5322 5391 +69
+ Misses 787 747 -40
|
3759a7c to
39e58f1
Compare
39e58f1 to
06283f7
Compare
marcalff
reviewed
Nov 4, 2024
marcalff
reviewed
Nov 4, 2024
Member
marcalff
left a comment
There was a problem hiding this comment.
Nice work.
Please check the PR comments, it seems entry for test_traceparent_header_name_valid_casing is duplicated.
See also minor comments.
ThomsonTan
reviewed
Nov 4, 2024
lalitb
reviewed
Nov 5, 2024
lalitb
reviewed
Nov 5, 2024
6cd196d to
ebaaaf3
Compare
lalitb
reviewed
Nov 5, 2024
lalitb
approved these changes
Nov 5, 2024
Member
lalitb
left a comment
There was a problem hiding this comment.
LGTM with nit comments. Thanks for working on this.
716c5fa to
bb5f91a
Compare
ThomsonTan
reviewed
Nov 5, 2024
ThomsonTan
approved these changes
Nov 6, 2024
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Nov 6, 2024
[API] Comply with W3C Trace Context (open-telemetry#3115)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74
Changes
SPEC_LEVEL=1.TraceContextTest&AdvancedTest.Details
The following lists shows all the failing tests. Checked box indicates that the changes in this PR have fixed the test.
Currently failing tests from TraceContextTest suite
Currently failing tests from AdvancedTest suite
NOTE: The tests above were part of test suites
TraceContextTest&AdvancedTest. These test suites Trace Context Level 1 support.Current Status
All tests now passing. Test suites ran -
TraceContextTest&AdvancedTest.Additional Tasks
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes