[TEST] Rename w3c_tracecontext_test to w3c_tracecontext_http_test_server#3132
Merged
marcalff merged 6 commits intoopen-telemetry:mainfrom Nov 8, 2024
Merged
[TEST] Rename w3c_tracecontext_test to w3c_tracecontext_http_test_server#3132marcalff merged 6 commits intoopen-telemetry:mainfrom
marcalff merged 6 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
lalitb
reviewed
Nov 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3132 +/- ##
==========================================
+ Coverage 87.12% 87.83% +0.71%
==========================================
Files 200 195 -5
Lines 6109 6136 +27
==========================================
+ Hits 5322 5389 +67
+ Misses 787 747 -40 |
17 tasks
lalitb
approved these changes
Nov 7, 2024
ThomsonTan
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rename was requested in PR #3115 to make it more clear that the
testartifact being built underextfor w3c trace context compliance is actually a test server.See this comment requesting this change.
Changes
ext/w3c_tracecontext_testdirectory toext/w3c_tracecontext_test_server.The CMake option has been kept as-is:
BUILD_W3CTRACECONTEXT_TEST.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes