Providing an abstract HTTP interface.#370
Merged
reyang merged 21 commits intoopen-telemetry:masterfrom Oct 24, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 94.91% 94.88% -0.03%
==========================================
Files 155 155
Lines 6882 6882
==========================================
- Hits 6532 6530 -2
- Misses 350 352 +2
|
Closed
reyang
reviewed
Oct 20, 2020
reyang
reviewed
Oct 20, 2020
ThomsonTan
approved these changes
Oct 20, 2020
reyang
reviewed
Oct 20, 2020
reyang
reviewed
Oct 20, 2020
reyang
reviewed
Oct 20, 2020
reyang
reviewed
Oct 20, 2020
pyohannes
reviewed
Oct 20, 2020
Contributor
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
Thanks for working on this. This will be an important part of our SDK.
Co-authored-by: Reiley Yang <reyang@microsoft.com>
pyohannes
reviewed
Oct 21, 2020
Co-authored-by: Johannes Tax <jtax@newrelic.com>
Co-authored-by: Johannes Tax <jtax@newrelic.com>
Co-authored-by: Johannes Tax <jtax@newrelic.com>
maxgolov
reviewed
Oct 21, 2020
maxgolov
reviewed
Oct 21, 2020
maxgolov
reviewed
Oct 21, 2020
pyohannes
reviewed
Oct 23, 2020
Contributor
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
I have some smaller questions. But pending those answered, this PR is ready to be merged and I'll approve it.
Co-authored-by: Johannes Tax <jtax@newrelic.com>
Co-authored-by: Johannes Tax <jtax@newrelic.com>
Co-authored-by: Johannes Tax <jtax@newrelic.com>
maxgolov
approved these changes
Oct 23, 2020
pyohannes
approved these changes
Oct 24, 2020
SamuelMarks
reviewed
Oct 24, 2020
|
|
||
| void OnError(nostd::string_view err) noexcept override | ||
| { | ||
| std::cout << " Error:" << err; |
SamuelMarks
reviewed
Oct 24, 2020
| Delete | ||
| }; | ||
|
|
||
| enum class SessionState |
There was a problem hiding this comment.
There are plenty of errors, e.g., libcurl https://curl.haxx.se/libcurl/c/libcurl-errors.html - some are specific to libcurl, others are specific to non HTTP/HTTPS protocols, but many would be found in any HTTP library
Member
Author
There was a problem hiding this comment.
Right. http_client implementer for libcurl, winInet, winhttp and others need to ensure to map all those library-specific errors to http_client error states.
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Oct 29, 2020
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Aug 31, 2025
…s-create-or-update-comment-digest Update peter-evans/create-or-update-comment digest to f2fea6b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the HTTP client API to be used across various exporters ( eg zipkin, azure monitor ) to communicate with remove telemetry servers/collectors.
In continuation with previous #309 PR which I have closed now due to copyright/license issues.
This closes #6
@maxgolov @pyohannes @ThomsonTan - please help reviewing this.