http client implementation using cross platform yhirose/cpp-httplib library#371
Closed
lalitb wants to merge 1 commit intoopen-telemetry:masterfrom
Closed
http client implementation using cross platform yhirose/cpp-httplib library#371lalitb wants to merge 1 commit intoopen-telemetry:masterfrom
lalitb wants to merge 1 commit intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 155 155
Lines 6882 6882
=======================================
Hits 6532 6532
Misses 350 350 |
lalitb
changed the title
jsuereth
reviewed
Oct 22, 2020
| // MIT License | ||
| // | ||
|
|
||
| #ifndef CPPHTTPLIB_HTTPLIB_H |
Contributor
There was a problem hiding this comment.
How is this library distributed?
should we "shade" this library behind a namespace so we don't wind up with version issues if someone pulls in a different version that is somehow not source compatible?
Contributor
|
I would suggest to abandon this and work either on:
We probably don't want to add this MIT-licensed code to our repo, as well as take dependency on it - it does not seem to be widely used in production. |
Member
Author
|
We are no longer going to use httplib as client library. |
Member
|
Superseded by #385. |
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Aug 31, 2025
…oid-0.x Update dependency rules_android to v0.6.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides header only http client implementation for HTTP client API (refer PR #370 ), internally using cross-platform header-only httplib library.
TBD - Unit test case, thread safe.
Please review it, while I would be adding TBD changes as part of this. This PR is dependent on #370