curl based implementation for http client api#385
curl based implementation for http client api#385reyang merged 34 commits intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 95.00% 94.71% -0.30%
==========================================
Files 171 175 +4
Lines 7186 7581 +395
==========================================
+ Hits 6827 7180 +353
- Misses 359 401 +42
|
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
jsuereth
left a comment
There was a problem hiding this comment.
This looks fine for CURL, but I have a few asks:
- Can you open a ticket about Bazel support and assign to me? I'll look into it.
- Can you update documentation for how to compile w/ CURL support (with a TODO on bazel). I think adding optional deps like these really need to be well documented on how to consume them, and what level of support they have.
pyohannes
left a comment
There was a problem hiding this comment.
Thanks for bringing this on the way. I added some suggestions and questions about points that are unclear to me.
Appreciate your help here @jsuereth . I have created the ticket #390 for bazel build, and assigned to you. Please feel free to take it up once this PR is merged. I will add documentation for this dependency, though I have mentioned few details in new ticket which will help you get going. |
|
Need to remove http_server from code coverage . It seems to be affecting the overall percentage. |
|
@reyang - We discussed this PR during community meeting. It should be fine to merge it. There is tiny drop in code coverage percentage I believe it should be acceptable. |
…ib-1.x Update dependency bazel_skylib to v1.8.0
This brings the CURL implementation for HTTP Client API, along with few minor changes in API.
TODO -