Skip to content

Define the repository scope#751

Merged
trask merged 6 commits intoopen-telemetry:masterfrom
trask:repository-scope
Aug 2, 2020
Merged

Define the repository scope#751
trask merged 6 commits intoopen-telemetry:masterfrom
trask:repository-scope

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Jul 22, 2020

This is an attempt to define the scope of this repository, mostly in relation to https://github.com/open-telemetry/opentelemetry-java, in order to help things to go to the right place.

If this scope is agreed upon, we can move https://github.com/open-telemetry/opentelemetry-java/tree/master/extensions/runtime_metrics over to this repository, and delete https://github.com/open-telemetry/opentelemetry-java/tree/master/extensions/logging/log4j2_extensions which was accidentally re-implemented in this repository (#735).

cc: @open-telemetry/java-approvers

Will wait for @jkwatson (back Jul 30) before making any decisions here, just want to get the ball rolling and hear any initial comments / feedback.

Comment thread docs/scope.md Outdated
* Emitting spans and metrics (and in the future logs)
* System metrics
* Logging integrations
* Spring integrations
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Spring integrations
* Framework integrations (e.g., Spring)

Honestly nothing comes to mind but there must be more frameworks than just Spring right? :D

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. Ratpack, Play :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think frameworks are covered under Instrumentation bullet above. Narrowed this down to Spring Boot starters for now(?)

@trask
Copy link
Copy Markdown
Member Author

trask commented Jul 29, 2020

One thing I didn't include, because I think may make more sense in SDK repo:

  • Integrations with other telemetry libraries, e.g.
    • OpenTracing
    • Micrometer
    • Spring Cloud Sleuth / Brave

but we can discuss also

@trask
Copy link
Copy Markdown
Member Author

trask commented Aug 2, 2020

Discussed with opentelemetry-java maintainers on Fri, and have agreement on this initial scope

@trask trask merged commit b9748e0 into open-telemetry:master Aug 2, 2020
@trask trask deleted the repository-scope branch August 2, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants