Remove log4j extension which was moved to instrumentation repo.#1513
Merged
carlosalberto merged 1 commit intoopen-telemetry:masterfrom Aug 6, 2020
Merged
Conversation
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
pavolloffay,
thisthat and
tylerbenson
as code owners
Member
|
Is the implementation in the instrumentation repo the same as the one in this repo? |
Contributor
Author
thisthat
approved these changes
Aug 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #1513 +/- ##
=========================================
Coverage 87.03% 87.03%
Complexity 1369 1369
=========================================
Files 163 163
Lines 5205 5205
Branches 490 490
=========================================
Hits 4530 4530
Misses 493 493
Partials 182 182 Continue to review full report at Codecov.
|
carlosalberto
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The major difference is that we haven't implemented a JSON layout there yet. FWIU, the default JSON layout can include context data variables automatically so I'm not sure if it's required, but we can reimplement it there right away if it's being used.
open-telemetry/opentelemetry-java-instrumentation#735
open-telemetry/opentelemetry-java-instrumentation#751