Add type hints to OTLP exporter#1121
Merged
lzchen merged 10 commits intoopen-telemetry:masterfrom Sep 17, 2020
Merged
Conversation
|
|
aabmass
reviewed
Sep 16, 2020
Member
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
Thanks for doing this, looks good just a few comments
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Show resolved
Hide resolved
...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py
Outdated
Show resolved
Hide resolved
aabmass
approved these changes
Sep 17, 2020
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Show resolved
Hide resolved
lzchen
approved these changes
Sep 17, 2020
6 tasks
alertedsnake
pushed a commit
to alertedsnake/opentelemetry-python
that referenced
this pull request
Sep 25, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* chore: adding plugin-fetch and example * chore: investigating failing test * chore: chore fixing tests with better fetch mocking * chore: addressing comments * chore: lint * chore: addressing comments * chore: updating webpack-env * chore: fixes after update for node types * chore: addressing reviews * chore: fixes after merge * chore: updating version Co-authored-by: Mayur Kale <mayurkale@google.com> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type hints were added to all functions in the OTLP exporter.
Fixes #1009
Type of change
How Has This Been Tested?
Ran mypy against the changed source files with the following command:
MYPYPATH="opentelemetry-api/src:opentelemetry-proto/src:opentelemetry-sdk/src:exporter/opentelemetry-exporter-otlp/src" mypy --namespace-packages --config=mypy-relaxed.ini --follow-imports=silent exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/No new errors were produced.
Also passes tox tests ran with
py3{5,6,7,8}-test-exporter-otlpChecklist: