Skip to content

Recording vs sampled#121

Merged
fbogsany merged 5 commits intoopen-telemetry:masterfrom
Shopify:recording-vs-sampled
Oct 16, 2019
Merged

Recording vs sampled#121
fbogsany merged 5 commits intoopen-telemetry:masterfrom
Shopify:recording-vs-sampled

Conversation

@fbogsany
Copy link
Copy Markdown
Contributor

@fbogsany fbogsany commented Oct 16, 2019

Includes #120

open-telemetry/opentelemetry-specification#291 states:

Span Processors will receive all spans with this flag (IsRecording) set. However, Span Exporter will not receive them unless the Sampled flag was set.

open-telemetry/opentelemetry-specification#296 replaced RECORD_AND_PROPAGATE with RECORD_AND_SAMPLED.

Copy link
Copy Markdown
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment.

@fbogsany fbogsany merged commit 3b52ae0 into open-telemetry:master Oct 16, 2019
@fbogsany fbogsany deleted the recording-vs-sampled branch October 16, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants