Update Sampler interface base on OTEP 0006-sampling#296
Merged
SergeyKanzhelev merged 7 commits intoopen-telemetry:masterfrom Oct 15, 2019
Merged
Update Sampler interface base on OTEP 0006-sampling#296SergeyKanzhelev merged 7 commits intoopen-telemetry:masterfrom
SergeyKanzhelev merged 7 commits intoopen-telemetry:masterfrom
Conversation
bogdandrutu
requested review from
AloisReitbauer,
SergeyKanzhelev,
c24t,
carlosalberto,
iredelmeier,
reyang,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
yurishkuro
reviewed
Oct 10, 2019
|
|
||
| Returns the sampling Decision for a `Span` to be created. | ||
|
|
||
| **Required arguments:** |
Member
There was a problem hiding this comment.
Would it make sense to generalize this, in light of #31? In Jaeger we recently extended the API to allow sampling decisions to be made later in the span life cycle
onCreateSpan(span: Span): SamplingDecision
onSetOperationName(span: Span, operationName: string): SamplingDecision
onSetTag(span: Span, key: string, value: any): SamplingDecision
Member
Author
There was a problem hiding this comment.
I think these are moments when the Sampler is called from the SDK perspective. I do agree that this is a nice to have config. Filed #307
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jkwatson
reviewed
Oct 14, 2019
| arguments collection. Description MUST be `NeverSampleSampler`. | ||
| These are the default samplers implemented in the OpenTelemetry SDK: | ||
|
|
||
| * ALWAYS_ON |
Contributor
There was a problem hiding this comment.
IMO, this isn't a particularly clear name. Can we make it ALWAYS_RETAIN and the other be ALWAYS_DROP ?
Member
Author
There was a problem hiding this comment.
Please file an issue to not forget about this.
carlosalberto
approved these changes
Oct 14, 2019
SergeyKanzhelev
approved these changes
Oct 14, 2019
Member
SergeyKanzhelev
left a comment
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
please apply suggested changes
Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com>
Member
Author
|
@yurishkuro please take another look. |
Member
|
This change was discussed in OTEP and hasn't received any requests for change. It also satisfied the requirement on # of approvals and almost a day passed since the last approval. No semantics changes were made in 5 days. So looks OK to merge for me. Merging |
SergeyKanzhelev
added a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Update Sampler interface base on OTEP 0006-sampling Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Fix comments from review Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update specification/sdk-tracing.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com> * Update specification/sdk-tracing.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com> * Update specification/sdk-tracing.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com> * Update specification/sdk-tracing.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com>
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Update Sampler interface base on OTEP 0006-sampling Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Fix comments from review Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update specification/sdk-tracing.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com> * Update specification/sdk-tracing.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com> * Update specification/sdk-tracing.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com> * Update specification/sdk-tracing.md Co-Authored-By: Sergey Kanzhelev <S.Kanzhelev@live.com>
schmikei
pushed a commit
to schmikei/opentelemetry-specification
that referenced
this pull request
Apr 17, 2025
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87
Fixes #33