Refactor Task Contributions #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## fs_task_contrib #1230 +/- ##
===================================================
+ Coverage 85.97% 86.59% +0.61%
===================================================
Files 105 105
Lines 2475 2484 +9
===================================================
+ Hits 2128 2151 +23
+ Misses 347 333 -14 ☔ View full report in Codecov by Sentry. |
florian-str
reviewed
Feb 8, 2024
florian-str
pushed a commit
that referenced
this pull request
Feb 21, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
Mar 10, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
May 12, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
May 29, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
Jun 12, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
Jun 26, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
MrSerth
added a commit
that referenced
this pull request
Sep 2, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
florian-str
pushed a commit
that referenced
this pull request
Sep 11, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
MrSerth
added a commit
that referenced
this pull request
Oct 2, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
MrSerth
added a commit
that referenced
this pull request
Oct 2, 2024
* Remove obsolete translations * Remove outdated ability specs for TaskContributions * Add missing path prefix to tasks#show * Reword task check for redirect_task_contribution * Use parent object rather than parent_id for tasks * Drop remaining view for TaskContributions#new * Refactor TaskContributions and TaskContributionsController The refactoring aims to move more logic into the model and simultaneously enhance the understandability of the controller. * Add missing edit? policy for TaskContribution * Fix updating existing TaskContributions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are in the process of introducing task contributions with #1103. While there is great progress already and a working core, I saw minor possibilities for suggestions. Instead of just making a few incoherent comments, I opted to make these suggestions with dedicated commits and this PR.
While doing so, I also fixed the failing specs, mainly to identify real errors introduced by my changes. Hence, I haven't validated the specs overall, that's still an open topic to double-check.
@florian-str Feel free to have a look and reuse my suggestions. They are just a starting point and might also serve as a foundation for further enhancements. They are designed to help you around, not in any way to minimise your great effort in implementing this important feature.