Skip to content

Conversation

@MrSerth
Copy link
Member

@MrSerth MrSerth commented Jul 12, 2024

In CodeOcean, we have a no_one policy that denies access to some actions. In CodeHarbor, we didn't add the policy when introducing Pundit, since it wasn't yet used. However, with #1230, we'll do so (and already did implicitly). Hence, we are adding the method here already and use it where appropriate

//cc @Melhaya for the boy scouting rule

@MrSerth MrSerth requested a review from Dome-GER July 12, 2024 14:14
@MrSerth MrSerth self-assigned this Jul 12, 2024
@codecov
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (4d760dd) to head (96528a3).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1524   +/-   ##
=======================================
  Coverage   93.44%   93.45%           
=======================================
  Files         115      115           
  Lines        2808     2810    +2     
=======================================
+ Hits         2624     2626    +2     
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dome-GER Dome-GER merged commit 1a1968c into master Jul 15, 2024
@Dome-GER Dome-GER deleted the policy-no_one branch July 15, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants