ICC 19.1.2: CXX17 Work-Arounds (Variant)#1157
Merged
ax3l merged 1 commit intoopenPMD:devfrom Dec 11, 2021
Merged
Conversation
The `Attribute` constructors with implicit variant conversion
sometimes do not work in ICC 19.1.2.
```
openPMD-api/src/RecordComponent.cpp(226): error: no instance of constructor "openPMD::Attribute::Attribute" matches the argument list
argument types are: (openPMD::Extent)
Attribute a(getExtent());
^
openPMD-api/include/openPMD/backend/Attribute.hpp(50): note: this candidate was rejected because arguments do not match
class Attribute :
^
openPMD-api/include/openPMD/backend/Attribute.hpp(50): note: this candidate was rejected because arguments do not match
class Attribute :
^
openPMD-api/include/openPMD/backend/Attribute.hpp(79): note: this candidate was rejected because arguments do not match
Attribute(resource r) : Variant(std::move(r))
^
```
Same work-around as for NVCC in openPMD#1103
ax3l
added a commit
to ax3l/warpx
that referenced
this pull request
Dec 8, 2021
Avoids that we need to apply work-arounds in openPMD-api 0.14.3 for some `std::variant` constructors that the older compiler did not parse well. openPMD/openPMD-api#1157
25 tasks
This was referenced Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Attributeconstructors with implicit variant conversion sometimes do not work in ICC 19.1.2.Same work-around as for NVCC in #1103
Seen on LLNL's Quartz supercomputer.
X-ref: BLAST-WarpX/warpx#2300