Fix Attribute constructor error on NVCC#1184
Merged
ax3l merged 1 commit intoopenPMD:devfrom Jan 27, 2022
Merged
Conversation
Member
|
Oh, I wonder how many of the work-arounds in: are still needed if we add this overload 🤩 |
ax3l
reviewed
Jan 27, 2022
| * Fix by explicitly instantiating resource | ||
| */ | ||
| template< typename T > | ||
| Attribute( T && val ) : Variant( resource( std::forward< T >( val ) ) ) |
Member
There was a problem hiding this comment.
Checked: <utility> already included.
ax3l
approved these changes
Jan 27, 2022
Member
ax3l
left a comment
There was a problem hiding this comment.
LGTM, lets potentially remove the previous work-arounds as a follow-up PR.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed in PIConGPU since both PIConGPU and openPMD-api switched to C++17:
Fix by explicitly instantiating
resource.