Merged
Conversation
c9c8d37 to
e294cc3
Compare
Contributor
|
Inconsistent iteration paddings are correctly read, but they are currently not stored after first parsing. |
ax3l
commented
Apr 26, 2022
ax3l
commented
Apr 26, 2022
Include path to file
If the padding is inconsistent, a later Iteration::open() needs the original filename. Trying to compute the filename from the expansion pattern will lead to wrong filenames.
Member
Author
|
To apply this fix (especially the third commit) on the |
This was referenced May 25, 2022
Member
Author
|
Ok I think I managed to backport this in #1282 now 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1118. The pattern issue returned 😱
[JSON] Failed opening a file '../samples/varying_pattern_0.json'