storeChunk: Add an overload for shared_ptr<T[]>#1296
Merged
ax3l merged 4 commits intoopenPMD:devfrom Aug 16, 2022
Merged
Conversation
Contributor
Author
|
Clang-6 with libcpp does not seem to know about this? We can revert the examples and tests again and just leave the overload? |
franzpoeschel
force-pushed
the
add-shared-ptr-of-array-overload
branch
from
592c298 to
34a9d6f
Compare
franzpoeschel
force-pushed
the
add-shared-ptr-of-array-overload
branch
from
34a9d6f to
339dc1d
Compare
franzpoeschel
force-pushed
the
add-shared-ptr-of-array-overload
branch
from
339dc1d to
691cfdf
Compare
eschnett
added a commit
to eschnett/openPMD-api
that referenced
this pull request
Nov 11, 2022
* dev: (70 commits) Docs: Recommend Static Build for Superbuilds (openPMD#1325) Python 3.11 (openPMD#1323) pybind11: v2.10.1+ (openPMD#1322) Add Attribute::getOptional<T>() and use to add some more dynamic datatype conversions at read time (openPMD#1278) Mapping between ADIOS steps and openPMD iterations (openPMD#949) Deprecate shareRaw (openPMD#1229) Fix append mode double attributes (openPMD#1302) Constant scalars: Don't flush double (openPMD#1315) Remove caching cmake vars (openPMD#1313) [pre-commit.ci] pre-commit autoupdate (openPMD#1311) storeChunk: Add an overload for shared_ptr<T[]> (openPMD#1296) Fix `operationAsString` Export (openPMD#1309) ADIOS2: more fine-grained control for file endings (openPMD#1218) [pre-commit.ci] pre-commit autoupdate (openPMD#1307) Fix file existence check in parallel tests (openPMD#1303) ADIOS2: Flush to disk within a step (openPMD#1207) [pre-commit.ci] pre-commit autoupdate (openPMD#1304) [pre-commit.ci] pre-commit autoupdate (openPMD#1295) Update catch2 to v2.13.9 (openPMD#1299) [pre-commit.ci] pre-commit autoupdate (openPMD#1292) ... # Conflicts: # .github/workflows/linux.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while working on #1294: With C++17, if you use
shared_ptr<T[]>, it will automatically select the right destructor, i.e.delete[].Note that our old version of
storeChunk<>()already supports this more or less on accident, since we usestd::decayinsidedetermineDatatypethen cast the shared_ptr down to void type. With giving this an explicit overload, we make the support more explicit to the user and also to ourselves, so we don't accidentally break this functionality in future.