Remove caching cmake vars#1313
Merged
ax3l merged 5 commits intoopenPMD:devfrom Sep 19, 2022
nischild:remove_caching_cmake_vars
Merged
Remove caching cmake vars#1313ax3l merged 5 commits intoopenPMD:devfrom nischild:remove_caching_cmake_vars
ax3l merged 5 commits intoopenPMD:devfrom
nischild:remove_caching_cmake_vars
Conversation
1 task
ax3l
approved these changes
Sep 19, 2022
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Thank you very much for the fix!
I never noticed this, because I set all these vars conditionally also in my super projects. But this makes sense, thx!
Member
|
@DerNils-git do you mind adding your IPP affiliation to your GitHub profile? That just helps me to keep track of who is who :) |
This was referenced Sep 19, 2022
eschnett
added a commit
to eschnett/openPMD-api
that referenced
this pull request
Nov 11, 2022
* dev: (70 commits) Docs: Recommend Static Build for Superbuilds (openPMD#1325) Python 3.11 (openPMD#1323) pybind11: v2.10.1+ (openPMD#1322) Add Attribute::getOptional<T>() and use to add some more dynamic datatype conversions at read time (openPMD#1278) Mapping between ADIOS steps and openPMD iterations (openPMD#949) Deprecate shareRaw (openPMD#1229) Fix append mode double attributes (openPMD#1302) Constant scalars: Don't flush double (openPMD#1315) Remove caching cmake vars (openPMD#1313) [pre-commit.ci] pre-commit autoupdate (openPMD#1311) storeChunk: Add an overload for shared_ptr<T[]> (openPMD#1296) Fix `operationAsString` Export (openPMD#1309) ADIOS2: more fine-grained control for file endings (openPMD#1218) [pre-commit.ci] pre-commit autoupdate (openPMD#1307) Fix file existence check in parallel tests (openPMD#1303) ADIOS2: Flush to disk within a step (openPMD#1207) [pre-commit.ci] pre-commit autoupdate (openPMD#1304) [pre-commit.ci] pre-commit autoupdate (openPMD#1295) Update catch2 to v2.13.9 (openPMD#1299) [pre-commit.ci] pre-commit autoupdate (openPMD#1292) ... # Conflicts: # .github/workflows/linux.yml
This was referenced Mar 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If openPMD is included into a CMake project as a subproject it modifies variables in or adds variables to the CACHE.
This can lead to conflicts in the parent project since these variables are overwritten in or set for the parent project.
Not adding variables to the CACHE limits the scope of variables to the openPMD project which makes it safer for other developers to add openPMD as a subproject.
This is a less invasive approach to the pull request #1312 and it is more complete since in #1312 only
CMAKE_RUNTIME_OUTPUT_DIRECTORYis substituted by a new openPMD specific variable.List of variables handled in this pull request:
Close #1312