CMake: Fix Build & Install Option Names#1326
Merged
ax3l merged 3 commits intoopenPMD:devfrom Dec 9, 2022
Merged
Conversation
ax3l
force-pushed
the
cmake-fix-dir-options
branch
from
8a32a2f to
551cc02
Compare
ax3l
force-pushed
the
cmake-fix-dir-options
branch
from
551cc02 to
d9462b6
Compare
ax3l
commented
Nov 3, 2022
ax3l
force-pushed
the
cmake-fix-dir-options
branch
from
d9462b6 to
cc7575e
Compare
nischild
approved these changes
Nov 4, 2022
Contributor
nischild
left a comment
nischild
left a comment
There was a problem hiding this comment.
I could not find any set(...) statements which could be mixed up with other variables in other projects besides CMAKE_CXX_FLAGS which is probably set to be used in subprojects.
s-sajid-ali
approved these changes
Nov 7, 2022
ax3l
force-pushed
the
cmake-fix-dir-options
branch
from
cc7575e to
0d51a7d
Compare
We should not overwrite `CMAKE_` variables but instead set our own. This corrects this. This also fixes that the cmake install path was unset in superbuilds failing the configure steps unless set by the calling project did set `CMAKE_INSTALL_CMAKEDIR`: ``` CMake Error at openpmd-src/CMakeLists.txt:1080 (install): install EXPORT given no DESTINATION! CMake Error at openpmd-src/CMakeLists.txt:1085 (install): install FILES given no DESTINATION! ```
ax3l
force-pushed
the
cmake-fix-dir-options
branch
from
0d51a7d to
0a71572
Compare
ax3l
commented
Dec 8, 2022
ax3l
force-pushed
the
cmake-fix-dir-options
branch
2 times, most recently
from
7810307 to
b0fe226
Compare
ax3l
force-pushed
the
cmake-fix-dir-options
branch
from
b0fe226 to
f5571bc
Compare
Member
Author
|
@franzpoeschel all green now :) |
This was referenced Mar 1, 2023
This was referenced Mar 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not overwrite
CMAKE_variables but instead set our own. This corrects this.This also fixes that the cmake install path was unset in superbuilds failing the configure steps unless set by the calling project did set
CMAKE_INSTALL_CMAKEDIR(or turnedopenPMD_INSTALL=OFF):seen with fnalacceleratormodeling/synergia2#100
Follow-up to #1313
cc @DerNils-git @s-sajid-ali