Skip to content

CMake: Multi-Config Generator#1384

Merged
ax3l merged 3 commits intoopenPMD:devfrom
ax3l:fix-examples-pdb
Mar 20, 2023
Merged

CMake: Multi-Config Generator#1384
ax3l merged 3 commits intoopenPMD:devfrom
ax3l:fix-examples-pdb

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Mar 1, 2023 •
edited
Loading

Set target properties for multi-config generators.

Fix #1383

Regression to #1326

@ax3l
CMake: Multi-Config Generator Quickfix
1d8e749 
Set target properties for multi-config generators.
@ax3l ax3l added this to the 0.15.0 milestone Mar 1, 2023
ax3l added a commit to ax3l/cmake-easyinstall that referenced this pull request Mar 1, 2023
@ax3l
openPMD: Test MSVC
94687b0 
testing openPMD/openPMD-api#1384
@ax3l
Copy link
Member Author

ax3l commented Mar 1, 2023 •
edited
Loading

Hm, does not yet work. Seems to actually collide on a vc143.pdb file in the runtime dir...

Update: solved by setting the COMPILE_PDB_NAME[_CFG] output name target properties.
Contrary to PDB_NAME, the default here is unspecified and seems to default to vc143.pdb

franzpoeschel
franzpoeschel reviewed Mar 2, 2023
View reviewed changes
ax3l added a commit to ax3l/cmake-easyinstall that referenced this pull request Mar 20, 2023
@ax3l
openPMD: Test MSVC
8b74a2d 
testing openPMD/openPMD-api#1384
@ax3l ax3l changed the title CMake: Multi-Config Generator Quickfix CMake: Multi-Config Generator Mar 20, 2023
@ax3l
Set: COMPILE_PDB_NAME[_CFG]
0ab0b22 
Contrary to `PDB_NAME`, the default here is unspecified
and seems to default to `vc143.pdb`
ax3l added a commit to ax3l/cmake-easyinstall that referenced this pull request Mar 20, 2023
@ax3l
openPMD: Test MSVC
14db911 
testing openPMD/openPMD-api#1384
@ax3l
Copy link
Member Author

ax3l commented Mar 20, 2023 •
edited
Loading

@franzpoeschel ok, now the parallel build works and is not a hack anymore :)

@franzpoeschel
Copy link
Contributor

franzpoeschel commented Mar 20, 2023

Nice!

So, what was missing is the COMPILE_PDB_NAME so that the different processes don't try accessing the same file?

@ax3l
Copy link
Member Author

ax3l commented Mar 20, 2023 •
edited
Loading

Yes, exactly. Seems it was unspecified and collided for different executables we build in parallel.
I added an update here: #1384 (comment)

@franzpoeschel
Copy link
Contributor

franzpoeschel commented Mar 20, 2023

I actually saw a similar issue in another of my PRs today (the eternal #824), I'll have to rebase and see if this fixes it :)

franzpoeschel
franzpoeschel approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@franzpoeschel franzpoeschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ax3l ax3l enabled auto-merge (squash) March 20, 2023 18:16
@ax3l ax3l merged commit bf385dd into openPMD:dev Mar 20, 2023
@ax3l ax3l deleted the fix-examples-pdb branch March 20, 2023 20:19
This was referenced Mar 26, 2023
Merged
Merged
ax3l
ax3l commented Mar 27, 2023
View reviewed changes
CMakeLists.txt
set_target_properties(openPMD.py PROPERTIES
COMPILE_PDB_NAME_${CFG_UPPER} openpmd_api_cxx
ARCHIVE_OUTPUT_DIRECTORY_${CFG_UPPER} ${openPMD_PYTHON_OUTPUT_DIRECTORY}/${CFG}/openpmd_api
LIBRARY_OUTPUT_DIRECTORY_${CFG_UPPER} ${openPMD_PYTHON_OUTPUT_DIRECTORY}/${CFG}/openpmd_api
Copy link
Member Author

@ax3l ax3l Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke my slightly arcane logic in setup.py for Windows.
Fix in #1400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franzpoeschel franzpoeschel franzpoeschel approved these changes

Assignees

@franzpoeschel franzpoeschel

Labels

bug install tests

Projects

None yet

Milestone

0.15.0

Development

Successfully merging this pull request may close these issues.

Examples: Fix Windows PDB

2 participants

@ax3l @franzpoeschel