Warn on BP5+Blosc in ADIOS2 v2.9 up to patch level 1#1497
Merged
ax3l merged 3 commits intoopenPMD:devfrom Aug 8, 2023
Merged
Conversation
5 tasks
ax3l
reviewed
Aug 8, 2023
ax3l
reviewed
Aug 8, 2023
ax3l
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are about to ship ADIOS2 v2.9 with our Python Wheel, we should maybe try to avoid that users fall into this trap.
I will add a second PR based on this that will warn on groupBased encoding. That second PR should probably not go into the current release cycle since the alternative (variableBased encoding) is not stable yet.