Merged
Conversation
Member
|
@franzpoeschel ready for rebase :) |
09f3077 to
97d2d7d
Compare
Contributor
Author
|
@ax3l You recently mentioned a workflow that you have where you repeatedly close and reopen an Iteration to write data to it. Since this workflow implies that you cannot use variable-based encoding, I assume that you use file-based encoding instead? |
97d2d7d to
ad5b6b7
Compare
Contributor
Author
|
I would like to adapt all examples and tests to this change. Since this requires more features for file-based enconding (e.g. reopening a closed iteration) and for variable-based encoding (e.g. random-access) alike, I will postpone this PR for now. |
ad5b6b7 to
2a321f3
Compare
185b37f to
88cc81f
Compare
d89e566 to
6e68d77
Compare
6e68d77 to
d868b27
Compare
This uncovered loads of bugs
d868b27 to
93ca7a7
Compare
1 task
ax3l
approved these changes
Dec 22, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should not go into 0.15 release cycle since it advises to use variable-based encoding
Add some environment variable or similar to deactivate thisThe warning is now only printed for the new ADIOS2 encoding (group table), so this does not affect legacy workflowsMaybe adapt testsPostponed to when variable-based encoding becomes more usefulEDIT:
adios2.usestepsoption is now removed, is automatically used ifWriteIterationsis used in the frontendMore context: #1457
The warning is printed only when using the (currently opt-in) group table feature, for the sake of a smoother transition for users.
We should soon make group tables opt-out. A good time would be when we have better support for variable-based encoding.
Breaking because: It's no longer possible to open ADIOS2 group-based files with linear access mode if they don't use the group table feature.