ADIOS2: Infrastructure & Docs Update#568
Merged
ax3l merged 7 commits intoopenPMD:devfrom Oct 15, 2019
Merged
Conversation
ax3l
added
refactoring
documentation
backend: ADIOS1
backend: ADIOS2
continuous integration
continuous deployment
ax3l
force-pushed
the
topic-adios2Updates
branch
from
6a7294c to
4036a7e
Compare
ax3l
force-pushed
the
topic-adios2Updates
branch
2 times, most recently
from
501230b to
1fd2a4b
Compare
ax3l
commented
Oct 7, 2019
.travis.yml
Outdated
| if [ -f $binary ]; then | ||
| kcov --exclude-pattern=/usr/,share/openPMD/thirdParty,/test/ ../coverage/$binary $binary; | ||
| fi; | ||
| - for OPENPMD_BP_PROVIDER in "ADIOS1" "ADIOS2"; do |
Member
Author
There was a problem hiding this comment.
not sure if that will work or just overwrite the results.
ax3l
force-pushed
the
topic-adios2Updates
branch
2 times, most recently
from
d20450e to
1cf6a2a
Compare
ax3l
force-pushed
the
topic-adios2Updates
branch
from
10de30a to
463f23c
Compare
ax3l
force-pushed
the
topic-adios2Updates
branch
3 times, most recently
from
9965e41 to
2177305
Compare
Due to old MPI instances on Trusty, we cannot compile ADIOS2. We first need to take a newer Ubuntu release before turning them on there.
Make declaration and implementation consistent.
Add an explicit cast from `openPMD::Extent`
(aka `std::vector< std::uint64_t >`) to `adios2::Dims`
(aka `std::vector< std::size_t >`) to avoid a compile error on
OSX:
```
include/openPMD/Datatype.hpp:558:23: error: no matching member function for call to 'operator()'
return action.OPENPMD_TEMPLATE_OPERATOR( )< char >(
~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/openPMD/Datatype.hpp:532:44: note: expanded from macro 'OPENPMD_TEMPLATE_OPERATOR'
^
src/IO/ADIOS/ADIOS2IOHandler.cpp:201:9: note: in instantiation of function template specialization 'openPMD::switchType<void, openPMD::detail::VariableDefiner, adios2::IO &, std::__1::basic_string<char> &, std::__1::unique_ptr<adios2::Operator, std::__1::default_delete<adios2::Operator> >, const std::__1::vector<unsigned long long, std::__1::allocator<unsigned long long> > &>' requested here
switchType( parameters.dtype, detail::VariableDefiner( ),
^
src/IO/ADIOS/ADIOS2IOHandler.cpp:794:5: note: candidate function not viable: no known conversion from 'const vector<unsigned long long, allocator<unsigned long long>>' to 'const vector<size_t, allocator<unsigned long>>' for 4th argument
operator( )( adios2::IO & IO, const std::string & name,
^
src/IO/ADIOS/ADIOS2IOHandler.cpp:804:27: note: candidate template ignored: invalid explicitly-specified argument for template parameter 'n'
void VariableDefiner::operator( )( adios2::IO &, Params &&... )
```
ax3l
force-pushed
the
topic-adios2Updates
branch
from
2177305 to
7c5e43f
Compare
ax3l
changed the title
This was referenced Oct 15, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further updates now that we have ADIOS2 #482 taking off 🚀 ✨
Dockerfileformanylinux2010build ADIOS 2.5.0: Static Build Issues Linking Blosc ornladios/ADIOS2#1810.bpfiles a runtime option (currently via environment variable)Extentcast causing a build errorFound bug during the process
ADIOS2 VariableDefiner: Fix OSX Cast Error
Add an explicit cast from
openPMD::Extent(akastd::vector< std::uint64_t >) toadios2::Dims(akastd::vector< std::size_t >) to avoid a compile error on OSX: