Merged
Conversation
ax3l
force-pushed
the
topic-delayDefaultADIOS2
branch
from
3f7462d to
50029e7
Compare
Since we are planning to add more refactoring in the internal (variables vs. attributes) representation of ADIOS2, let's not make this default over ADIOS1 yet to avoid writing files that cannot be read again soon. Delay this just for a little for this upcoming release, so we can draft a new version without changing defaults yet. (I want to release a new version very soon to fix some installation issues and other updates that we accumulated.)
ax3l
force-pushed
the
topic-delayDefaultADIOS2
branch
from
50029e7 to
6fdc197
Compare
Member
Author
|
ping @franzpoeschel is this fine with you, too? Just want to push a bug-fix release and the ADIOS2 files we write will probably change with your further updates for read speed, I guess? |
Contributor
|
@ax3l This is ok as long as the ADIOS2 backend hasn't stabilized yet. I have already implemented the necessary changes on topic-streaming and will backport them to dev soon. Those changes do not affect the layout of the BP4 file, since the implementation does not add ADIOS variables for groups, unlike initially planned. (see here) |
Contributor
Member
Author
Okay, thanks for the heads-up on this. I wasn't sure anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are planning to add more refactoring in the internal (variables vs. attributes) representation of ADIOS2, let's not make this default over ADIOS1 yet to avoid writing files that soon cannot be read again.
Delay this just for a little for this upcoming release, so we can draft a new version without changing defaults yet. (I want to release a new version very soon to fix some installation issues and other updates that we accumulated.)
Delays the new defaults to ADIOS2 in #568 for a later release.