Skip to content

CI: ICC/ICPC & ICX/ICPX#870

Merged
ax3l merged 2 commits intoopenPMD:devfrom
ax3l:ci-icc
Feb 25, 2021
Merged

CI: ICC/ICPC & ICX/ICPX#870
ax3l merged 2 commits intoopenPMD:devfrom
ax3l:ci-icc

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Jan 4, 2021

  • Add Intel icc/icpc from oneAPI to CI.
  • Add Intel icx/icpx from oneAPI to CI.

@ax3l ax3l changed the title CI: ICC/ICPC CI: ICC/ICPC & ICX/ICPX Feb 23, 2021
@ax3l ax3l requested a review from franzpoeschel February 23, 2021 17:28
@ax3l
Copy link
Member Author

ax3l commented Feb 23, 2021

Ready for merge, just depends on fix for ICC (regression of #931)

@franzpoeschel
Copy link
Contributor

franzpoeschel commented Feb 24, 2021

Hmm, tests are failing now:

[~Series] An error occurred: Dynamic cast returned a nullptr!

Funny enough, tests run fine when building PR #886 with icc, so I think that cleaning up our hierarchy representation really has its merits. I'd propose to wait for #886 before merging this one?
I've opened a demonstration PR #934 that rebases this one onto #886 to show this.

ax3l and others added 2 commits February 25, 2021 10:00
Add Intel `icc`/`icpc` and `icx`/`ixpc` from oneAPI to CI.
@ax3l ax3l merged commit aa63224 into openPMD:dev Feb 25, 2021
@ax3l ax3l deleted the ci-icc branch February 25, 2021 20:01
@ax3l
Copy link
Member Author

ax3l commented Feb 25, 2021

Horray, ICC & ICX coverage added :) Thanks for the fix, @franzpoeschel! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants