[WIP] Demonstrator: Fix ICC builds#934
Closed
franzpoeschel wants to merge 8 commits intoopenPMD:devfrom
Closed
Conversation
Fix invasive tests
Make AttributableImpl destructor virtual Rename Attributable -> LegacyAttributable Use Attributable::retrieveSeries for Writable::flushSeries
Make BASEPATH a member of SeriesImpl Documentation for Series
This is stolen from PR openPMD#804. This PR fixes the issues from that one, so those tests are passing now.
Add Intel `icc`/`icpc` and `icx`/`ixpc` from oneAPI to CI.
franzpoeschel
force-pushed
the
fix-switchtype-icc
branch
from
80aefcd to
f481d93
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things to fix:
switchTypetemplates were too wild foricc. This PR changes the SFINAE conditions a bit soiccaccepts it again.iccbuilds had failing tests[~Series] An error occurred: Dynamic cast returned a nullptr!. Since PR Split Series into an internal and an external class #886 addresses exactly that kind of error, this builds upon that PR, fixing the error.This PR will probably not be merged, it's just for demonstrating which PRs need to be merged in order, for fixing
iccbuilds.Currently, it's #870 rebased onto #886.