Demonstrator PR to check whether our ICC tests are broken on dev#953
Closed
franzpoeschel wants to merge 2 commits intoopenPMD:devfrom
Closed
Demonstrator PR to check whether our ICC tests are broken on dev#953franzpoeschel wants to merge 2 commits intoopenPMD:devfrom
franzpoeschel wants to merge 2 commits intoopenPMD:devfrom
Conversation
icc tests are giving me weird errors on multiple independent PRs "unitSI scaling during chunk loading not yet implemented" See: https://github.com/openPMD/openPMD-api/pull/901/checks?check_run_id=2224675773
7 tasks
2 tasks
Member
|
Thanks! Addressed in #954 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
icc tests are giving me weird errors on multiple independent PRs
"unitSI scaling during chunk loading not yet implemented"
See:
https://github.com/openPMD/openPMD-api/pull/901/checks?check_run_id=2224675773
It looks like the
std::numeric_limits<double>::quiet_NaN()that we use as a default value for scaling and check viastd::isnan()is not returningtrueanymore with the latest ICC.Issue worked around on #938 by this commit (using our
auxiliary::Optioninstead).