RecordComponent: Remove Unimplemented Scaling#954
Merged
ax3l merged 3 commits intoopenPMD:devfrom Mar 31, 2021
Merged
Conversation
Make this a public class, so we can use it in user-facing interfaces.
Somehow, it doesn't properly recognize NaNs, so let's try an auxiliary::Option.
ax3l
changed the title
Remove unimplemented `targetUnitSI` argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the latest ICPX release, it looks like the quiet NaN's we used as a default argument do not yield
trueanymore instd::nan. This is confusing... but we will change the default value anyway. #953 https://godbolt.org/z/fbca5ffnPauxiliary::Option: Make this a public class, so we can use it in user-facing interfaces.RecordComponent-> remove unused parameter altogether