Add idempotency protection to B #145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickevansuk
reviewed
Aug 4, 2023
Comment on lines
-290
to
+292
| if (!result) throw new OpenBookingException(new OrderAlreadyExistsError()); | ||
| if (!result) return CreateOrderResult.OrderAlreadyExists; | ||
|
|
||
| return CreateOrderResult.OrderSuccessfullyCreated; |
Contributor
There was a problem hiding this comment.
Noting that this abstraction - the idea of moving the throwing of the OrderAlreadyExistsError into the StoreBookingEngine - is excellent.
It is however, a breaking change for users of the library.
Will break this out into a separate issue to capture it for future.
Contributor
|
Closing as this has now been mostly implemented in #207, with a separate issue to capture the remaining functionality created in #208. Thanks so much for your work on this all those years ago @matdavies ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When finished, should fix #100
Currently draft format. Per the comment here, I have attempted to change the return type of ProcessFlowResult. Could not just return a string, as
ProcessCheckpointuses the orderQuote to determine the HttpStatusCode to return, so added aProcessFlowResultobject to contain both the string to return and this value.I'm not sure about this though, design-wise, as it is adding an Http dependency to the CustomBookingEngine which may violate some design principles here, so throwing this up as a draft for review.