Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
rm-openai
force-pushed
the
dev/rm/websearch
branch
from
2e1ce73 to
16d9b74
Compare
rm-openai
changed the title
rm-openai
force-pushed
the
dev/rm/websearch
branch
2 times, most recently
from
a3d7fe4 to
272e6b8
Compare
rm-openai
force-pushed
the
dev/rm/websearch
branch
from
6dffc92 to
bba8eac
Compare
pakrym-oai
reviewed
Mar 6, 2026
| } | ||
| } | ||
|
|
||
| fn serialize_web_search_filters<S>( |
Collaborator
There was a problem hiding this comment.
why does this need a custom serializer?
Collaborator
There was a problem hiding this comment.
do we export this type as app_server protocol?
cc: @owenlin0
Collaborator
There was a problem hiding this comment.
took a look - luckily no, this is only used for codex harness -> responsesapi calls. opened a PR to clean this up while I am here: #14136
pakrym-oai
reviewed
Mar 6, 2026
codex-rs/core/src/config/mod.rs
Outdated
| (None, None) => None, | ||
| (Some(base_location), None) => Some(base_location.clone()), | ||
| (None, Some(profile_location)) => Some(profile_location.clone()), | ||
| (Some(base_location), Some(profile_location)) => Some(WebSearchLocation { |
Collaborator
There was a problem hiding this comment.
can we maybe add .merge() helpers to these. types?
pakrym-oai
approved these changes
Mar 6, 2026
Collaborator
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
let's make merging less verbose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we could only configure whether web search was on/off.
This PR enables sending along a web search config, which includes all the stuff responsesapi supports: filters, location, etc.