Skip to content

fix(core): use dedicated types for responsesapi web search tool config#14136

Merged
owenlin0 merged 1 commit intomainfrom
owen/clean_up_custom_serializers
Mar 9, 2026
Merged

fix(core): use dedicated types for responsesapi web search tool config#14136
owenlin0 merged 1 commit intomainfrom
owen/clean_up_custom_serializers

Conversation

@owenlin0
Copy link
Collaborator

@owenlin0 owenlin0 commented Mar 9, 2026

This changes the web_search tool spec in codex-core to use dedicated Responses-API payload structs instead of shared config types and custom serializers.

Previously, ToolSpec::WebSearch stored WebSearchFilters and WebSearchUserLocation directly and relied on hand-written serializers to shape the outgoing JSON. This worked, but it mixed config/schema types with the OpenAI Responses payload contract and created an easy place for drift if those shared types changed later.

Why

This keeps the boundary clearer:

  • app-server/config/schema types stay focused on config
  • Responses tool payload types stay focused on the OpenAI wire format

It also makes the serialization behavior obvious from the structs themselves, instead of hiding it in custom serializer functions.

@owenlin0 owenlin0 marked this pull request as ready for review March 9, 2026 21:21
@owenlin0
Copy link
Collaborator Author

owenlin0 commented Mar 9, 2026

@codex review

@owenlin0 owenlin0 force-pushed the owen/clean_up_custom_serializers branch from e7ddd3c to a0d8965 Compare March 9, 2026 21:23
@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@owenlin0 owenlin0 requested a review from rm-openai March 9, 2026 21:27
@owenlin0 owenlin0 enabled auto-merge (squash) March 9, 2026 21:29
@owenlin0 owenlin0 disabled auto-merge March 9, 2026 21:58
@owenlin0 owenlin0 merged commit d309c10 into main Mar 9, 2026
27 of 31 checks passed
@owenlin0 owenlin0 deleted the owen/clean_up_custom_serializers branch March 9, 2026 21:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants