Conversation
This was referenced Apr 17, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9015f3683d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
force-pushed
the
pr18274
branch
3 times, most recently
from
18fc17a to
577cde3
Compare
viyatb-oai
reviewed
Apr 17, 2026
viyatb-oai
reviewed
Apr 17, 2026
bolinfest
force-pushed
the
pr18274
branch
5 times, most recently
from
f7496e7 to
f3ff42a
Compare
viyatb-oai
reviewed
Apr 17, 2026
viyatb-oai
approved these changes
Apr 17, 2026
Collaborator
viyatb-oai
left a comment
viyatb-oai
left a comment
There was a problem hiding this comment.
one remaining finding but otherwise looks in a good shape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PermissionProfileneeds stable, canonical file-system semantics before it can become the primary runtime permissions abstraction. Without a canonical form, callers have to keep re-deriving legacy sandbox maps and profile comparisons remain lossy or order-dependent.What changed
This adds canonicalization helpers for
FileSystemPermissionsandPermissionProfile, expands special paths into explicit sandbox entries, and updates permission request/conversion paths to consume those canonical entries. It also tightens the legacy bridge so root-wide write profiles with narrower carveouts are not silently projected as full-disk legacy access.Verification
cargo test -p codex-protocol root_write_with_read_only_child_is_not_full_disk_write -- --nocapturecargo test -p codex-sandboxing permission -- --nocapturecargo test -p codex-tui permissions -- --nocapture