Hash server url #564
Hash server url #564
Conversation
| const QString buttonText = tr("Open Download Page"); | ||
| notification.setButtons({buttonText}); | ||
| auto *sysNotification = ocApp()->systemNotificationManager()->notify(std::move(notification)); | ||
| connect(sysNotification, &SystemNotification::buttonClicked, this, [buttonText, url](const QString &button) { |
There was a problem hiding this comment.
how often do I get the notification? 🤔 once per software restart?
There was a problem hiding this comment.
Is the effort reasonably to show it only once per new available version? There might be users who can't install an update without an admin, so they can't do anything about the notification.
There was a problem hiding this comment.
The system notification is usually only displayed for a couple of seconds, so it's not too intrusive.
If we wanted to implement a "skip this update" functionality, we would need to persist the decision. Also, we would need to add a second action to the notification, which is currently not implemented on Mac.
There was a problem hiding this comment.
sounds all reasonable :-) thank you!
| updateJob->start(); | ||
| } else { | ||
| qCWarning(lcUpdateNotifier) << u"Update check failed with HTTP code" << job->httpStatusCode(); | ||
| qCWarning(lcUpdateNotifier) << u"Update check config.json with HTTP code" << job->httpStatusCode(); |
There was a problem hiding this comment.
are the warnings user facing? because then they'd be very technical 🙈
No description provided.