Skip to content

feat: send server url sha256 encoded to update server #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexAndBear merged 3 commits into from
Oct 7, 2025
Merged

feat: send server url sha256 encoded to update server #1311

AlexAndBear merged 3 commits into from
Oct 7, 2025

Conversation

@AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Oct 2, 2025

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear requested review from Copilot and kulmann October 2, 2025 15:36
Copilot AI reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Hashes the server URL before sending it to the update endpoint to avoid transmitting the raw URL.

  • Add SHA-256 hashing (noble-hashes) of serverUrl and send hex digest instead of plain URL.
  • Introduce new imports for hashing utilities.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

kulmann
kulmann requested changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change per se, but could you please check with @TheOneRing that the resulting hash is the exact same for desktop and web? 😇

kulmann
kulmann reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase now 🙈

@TheOneRing
Copy link

TheOneRing commented Oct 7, 2025

Related: opencloud-eu/desktop#564

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Oct 7, 2025

needs a rebase now 🙈

Sounds like a perfect time to add some tests ;)

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Oct 7, 2025

@TheOneRing please confirm that we generate the same hashes

https://host.docker.internal:9200/ -> 4401822c2b42930d40ec436c0effbc66940570ebf7f3d79093cc0976b65f2aab
https://demo.opencloud.eu/ -> 35e349562cb03c7594ce009d64d50d15d58269e4e1df145bdbdc813137e43e60

@AlexAndBear AlexAndBear requested a review from kulmann October 7, 2025 11:42
@AlexAndBear AlexAndBear merged commit 3cfdc8d into main Oct 7, 2025
27 of 28 checks passed
@AlexAndBear AlexAndBear deleted the issues/1308 branch October 7, 2025 15:02
@openclouders openclouders mentioned this pull request Oct 7, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kulmann kulmann kulmann approved these changes

Assignees

No one assigned

Labels

Type:Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hash serverUrl in requests to update server

4 participants

@AlexAndBear @TheOneRing @kulmann