feat: dispatch pathchange event for external integrations #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a pathchange event dispatch mechanism to enable external integrations to react to route changes in the OpenCloud web runtime. The implementation dispatches a custom event whenever the route path changes.
- Added a router.afterEach hook to monitor route changes
- Dispatches a custom "pathchange" event with route details when the path changes
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kulmann
reviewed
Jul 31, 2025
| } | ||
|
|
||
| const event = new CustomEvent('pathchange', { | ||
| detail: { |
Contributor
There was a problem hiding this comment.
Suggested change
| detail: { | |
| details: { |
why not plural form?
Contributor
Author
There was a problem hiding this comment.
The singular detail keyword is an unwritten
Best practice see:
https://developer.mozilla.org/de/docs/Web/API/CustomEvent/CustomEvent
https://gist.github.com/tonysamperi/0e73f8489000e8261600a92af92748c1
kulmann
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes