Skip to content

feat: dispatch pathchange event for external integrations #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexAndBear merged 3 commits into from
Aug 1, 2025
Merged

feat: dispatch pathchange event for external integrations #1033

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d436ac
feat: dispatch pathchange event for external integrations
AlexAndBear Jul 30, 2025
426cfdc
Apply suggestion from @Copilot
AlexAndBear Jul 30, 2025
8675641
expose less data
AlexAndBear Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/web-runtime/src/router/setupRouter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,24 @@ import { useModals } from '@opencloud-eu/web-pkg/src'
import { Router } from 'vue-router'

export const setupRouterHooks = (router: Router) => {
// Automatically close all open modals before each route change
router.beforeEach(() => {
const modalsStore = useModals()
modalsStore.removeAllModals()
})

// Dispatch a "pathchange" event after navigation for external integrations to react to
router.afterEach((to, from) => {
if (to.path === from.path) {
return
}

const event = new CustomEvent('pathchange', {
detail: {
Copy link
Contributor

@kulmann kulmann Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
detail: {
details: {

why not plural form?

Copy link
Contributor Author

@AlexAndBear AlexAndBear Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The singular detail keyword is an unwritten

Best practice see:

https://developer.mozilla.org/de/docs/Web/API/CustomEvent/CustomEvent

https://gist.github.com/tonysamperi/0e73f8489000e8261600a92af92748c1

to: { url: new URL(to.fullPath, window.location.origin).href, name: to.name },
from: { name: from.name, url: new URL(from.fullPath, window.location.origin).href }
}
})
window.dispatchEvent(event)
})
}