fix: space description doesn't collapse #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where space descriptions weren't properly collapsing by updating the CSS class handling and styling for markdown containers in the space header component.
- Simplified the markdown collapse functionality by removing JavaScript-based class toggling
- Added CSS-only solution for collapsing markdown containers
- Enhanced text editor styling with transparent background and full width
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
163
to
164
| markdownCollapsed.value = !unref(markdownCollapsed) | ||
| unref(markdownContainerRef).classList.toggle(markdownContainerCollapsedClass) | ||
| } |
There was a problem hiding this comment.
The removal of the class toggle line creates an incomplete implementation. The markdownContainerCollapsedClass variable is likely still defined but no longer used, creating dead code that should be cleaned up.
JammingBen
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes