Skip to content

fix: space description doesn't collapse #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexAndBear merged 2 commits into from
Sep 11, 2025
Merged

fix: space description doesn't collapse #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db45fb4
fix: space description doesn't collapse
AlexAndBear Sep 10, 2025
b1e5533
update snapshots
AlexAndBear Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/web-app-files/src/components/Spaces/SpaceHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@
v-else-if="markdownResource && markdownContent"
ref="markdownContainerRef"
class="markdown-container flex"
:class="{ 'mask-linear-[180deg,black,transparent]': markdownCollapsed }"
:class="{ 'mask-linear-[180deg,black,transparent] collapsed': markdownCollapsed }"
>
<text-editor
class="markdown-container-content"
class="markdown-container-content w-full"
is-read-only
:current-content="markdownContent"
/>
Expand Down Expand Up @@ -161,8 +161,8 @@ const toggleMarkdownCollapsedText = computed(() => {
})
const toggleMarkdownCollapsed = () => {
markdownCollapsed.value = !unref(markdownCollapsed)
unref(markdownContainerRef).classList.toggle(markdownContainerCollapsedClass)
}
Comment on lines 163 to 164
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the class toggle line creates an incomplete implementation. The markdownContainerCollapsedClass variable is likely still defined but no longer used, creating dead code that should be cleaned up.

Copilot uses AI. Check for mistakes.

const onMarkdownResize = () => {
if (!unref(markdownContainerRef)) {
return
Expand Down Expand Up @@ -316,8 +316,13 @@ const openSideBarSharePanel = () => {
.space-header-squashed .space-header-image {
@apply hidden lg:block;
}

.space-header .markdown-container.collapsed {
@apply max-h-[100px] overflow-hidden;
}

.space-header .markdown-container #text-editor-preview-component {
@apply !bg-transparent;
}
}
</style>
2 changes: 1 addition & 1 deletion packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceHeader.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ exports[`SpaceHeader > space description > should show the description 1`] = `
</button>
</div>
<!--v-if-->
<div class="markdown-container flex mask-linear-[180deg,black,transparent]">
<div class="markdown-container flex mask-linear-[180deg,black,transparent] collapsed">
<!---->
<div class="markdown-container-edit ml-2"><a attrs="[object Object]" aria-label="Edit description" class="oc-button-secondary oc-button-raw oc-button-secondary-raw gap-2 justify-center text-sm min-h-3 oc-button inline-flex cursor-pointer disabled:opacity-60 disabled:cursor-default p-1"></a></div>
</div>
Expand Down