fix: plain view logo UI #1396
Merged
fix: plain view logo UI #1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't load the plain view logo on `/` routes because it would cause a flickering on regular page reloads.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes UI issues in the plain view layout by preventing logo flickering on root routes and standardizing card styling across plain view pages.
- Prevents loading the plain view logo on
/routes to eliminate flickering during page reloads - Removes the
bg-role-surface-containerclass from card components to use default surface color - Converts the Plain layout component from Options API to Composition API
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/layouts/Plain.vue | Converts to Composition API and adds conditional logo rendering to prevent flickering |
| packages/web-runtime/src/pages/accessDenied.vue | Removes custom background color class from card |
| packages/web-runtime/src/pages/logout.vue | Removes custom background color class from card |
| packages/web-runtime/src/pages/missingOrInvalidConfig.vue | Removes custom background color class from card |
| packages/web-runtime/src/pages/oidcCallback.vue | Removes custom background color class from card |
| packages/web-runtime/src/pages/resolvePrivateLink.vue | Removes custom background color class and refactors card props |
| packages/web-runtime/src/pages/resolvePublicLink.vue | Removes custom background color class from card |
| packages/web-runtime/tests/unit/pages/snapshots/accessDenied.spec.ts.snap | Updates snapshot to reflect background color class removal |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
force-pushed
the
fix/plain-view-logo
branch
from
b7b7a7f to
f054412
Compare
Adjusts the card background color on plain views to the regular surface color to match the default login form.
JammingBen
force-pushed
the
fix/plain-view-logo
branch
from
f054412 to
aee8417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/routes because it would cause a flickering on regular page reloads.access-denied.refs #1394