Skip to content

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Nov 12, 2025

See 290fe42 for the actual change.

fixes #1597

@JammingBen JammingBen self-assigned this Nov 12, 2025
Copilot AI review requested due to automatic review settings November 12, 2025 08:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where file versions were not properly displayed when closing and re-opening the sidebar. The fix ensures that when the sidebar is closed, both the resource modification time and versions array are properly reset to prevent stale data from persisting.

Key Changes

  • Reset currentResourceMtime to undefined when the sidebar is closed to ensure fresh version data is loaded on re-open

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💪

@JammingBen JammingBen merged commit 5ac36ac into main Nov 17, 2025
28 checks passed
@JammingBen JammingBen deleted the fix/versions-not-showing branch November 17, 2025 15:19
@JammingBen
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
stable-4.2

Questions ?

Please refer to the Backport tool documentation

openclouders pushed a commit that referenced this pull request Nov 17, 2025
fix: missing versions when closing and re-opening sidebar
@openclouders openclouders mentioned this pull request Nov 17, 2025
1 task
@openclouders openclouders mentioned this pull request Dec 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Versions missing when sidebar is being closed and re-opened

3 participants