Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

related #1594

read from clipboard for webkit browser

Copilot AI review requested due to automatic review settings November 13, 2025 13:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a WebKit-specific workaround for reading link URLs from the clipboard after creating a link. The changes enable clipboard reading for WebKit browsers by adding the necessary permissions, eliminating the need for the previous API response fallback.

  • Removed WebKit-specific workaround that read link URLs from API responses
  • Added clipboard-read permission for WebKit browsers
  • Unified link URL retrieval to use clipboard reading across all browsers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/e2e/support/objects/app-files/link/actions.ts Removed WebKit-specific conditional logic and unused config import, now consistently uses clipboard reading for all browsers
tests/e2e/support/environment/actor/shared.ts Added clipboard-read permission for WebKit browsers and refactored browser type checking to use array inclusion

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JammingBen
Copy link
Contributor

Apparently it still fails in CI...? Works locally with Safari though 🤔

@ScharfViktor
Copy link
Contributor Author

Apparently it still fails in CI...?

but why? it should work

maybe due difference operation systems? I run on mac oc, CI uses linux

@JammingBen
Copy link
Contributor

but why? it should work

maybe due difference operation systems? I run on mac oc, CI uses linux

Could be... The test passes for me locally. Which makes it the only plausible issue I can think of right now.

@ScharfViktor
Copy link
Contributor Author

I found, it doesn't work in headless WebKit on Linux microsoft/playwright#34307 (comment)

I think we can close it and continue to use a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants