Skip to content

adjust tests after fixing #1594 #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ScharfViktor wants to merge 1 commit into from
Closed

adjust tests after fixing #1594 #1612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/e2e/support/environment/actor/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ export const buildBrowserContextOptions = (options: ActorOptions): BrowserContex
const basePermissions: string[] = []

// Clipboard permissions supports only in Chromium-based browsers
if (browserName === 'chromium' || browserName === 'chrome' || browserName === 'msedge') {
if (browserName === 'webkit') {
return [...basePermissions, 'clipboard-read']
} else if (['chromium', 'chrome', 'msedge'].includes(browserName)) {
return [...basePermissions, 'clipboard-read', 'clipboard-write']
}
return basePermissions
Expand Down
12 changes: 3 additions & 9 deletions tests/e2e/support/objects/app-files/link/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import util from 'util'
import { sidebar } from '../utils'
import { getActualExpiryDate } from '../../../utils/datePicker'
import { clickResource } from '../resource/actions'
import { config } from '../../../../config'
import { checkA11yOrLocalization } from '../../../utils/accessibility'

export interface createLinkArgs {
Expand Down Expand Up @@ -162,14 +161,9 @@ export const createLink = async (args: createLinkArgs): Promise<string> => {
])
await clearCurrentPopup(page)

// workaround for webkit (safari browser). See bug #1169
if (config.browser === 'webkit') {
return (await resp[0].json()).link.webUrl
} else {
const name =
process.env.RUN_LOCALIZATION_TEST_FOR_LANG === 'de' ? 'Unbenannter Link' : 'Unnamed link'
return await getRecentLinkUrl(page, name)
}
const name =
process.env.RUN_LOCALIZATION_TEST_FOR_LANG === 'de' ? 'Unbenannter Link' : 'Unnamed link'
return await getRecentLinkUrl(page, name)
}

export const changeRole = async (args: changeRoleArgs): Promise<string> => {
Expand Down