fix: exclude public links from space member count #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the space member count logic to exclude public links by adding a filter to the API call.
- Added a filter condition to the API call to ignore entries with an empty "grantedToV2" field.
- Maintained the fallback member count value at 1 if the count is missing.
| space.id, | ||
| sharesStore.graphRoles, | ||
| { count: true } | ||
| { count: true, filter: "grantedToV2 ne ''" } |
There was a problem hiding this comment.
Consider extracting the filter criteria into a named constant or adding an inline comment to explain why 'grantedToV2 ne ""' is used. This can improve clarity and maintainability by avoiding the use of a magic string.
Suggested change
| { count: true, filter: "grantedToV2 ne ''" } | |
| { count: true, filter: GRANTED_TO_FILTER } |
kulmann
approved these changes
Jun 11, 2025
AlexAndBear
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #812.
Needs opencloud-eu/opencloud#996 to work properly, although it doesn't destroy anything without, so it can be merged independently.