Skip to content

fix: exclude public links from space member count #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JammingBen merged 1 commit into from
Jun 11, 2025
Merged

fix: exclude public links from space member count #815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web-app-files/src/components/Spaces/SpaceHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ watch(
space.id,
space.id,
sharesStore.graphRoles,
{ count: true }
{ count: true, filter: "grantedToV2 ne ''" }
Copy link

Copilot AI Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider extracting the filter criteria into a named constant or adding an inline comment to explain why 'grantedToV2 ne ""' is used. This can improve clarity and maintainability by avoiding the use of a magic string.

Suggested change
{ count: true, filter: "grantedToV2 ne ''" }
{ count: true, filter: GRANTED_TO_FILTER }

Copilot uses AI. Check for mistakes.
)
memberCount.value = count || 1
} catch (e) {
Expand Down