Skip to content

feat: add open with context menu item #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexAndBear merged 2 commits into from
Jun 12, 2025
Merged

feat: add open with context menu item #820

AlexAndBear merged 2 commits into from
Jun 12, 2025

Conversation

@AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jun 11, 2025 •
edited
Loading

Description

image

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear force-pushed the issues/773 branch 2 times, most recently from ac091e4 to fb7c45c Compare June 11, 2025 21:43
@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Jun 11, 2025 •
edited by ScharfViktor
Loading

Todos:

  • check with @kulmann and @JammingBen if we match the acceptance criteria and implementation match our code standards
  • Support mobile devices
  • Open action: check if app can open in secure view (see todo in code)
  • Hover closes drop (follow up)
  • Keyboard navigation (followup)
  • Open with sometimes opens automatically (followup)
  • add unit tests (follow up)
  • add / fix e2e tests (follow up) @ScharfViktor open file using context menu #835

@AlexAndBear AlexAndBear force-pushed the issues/773 branch 4 times, most recently from e2c37d5 to 336ed57 Compare June 12, 2025 01:29
AlexAndBear
AlexAndBear commented Jun 12, 2025
View reviewed changes
packages/design-system/src/components/OcDrop/OcDrop.vue
}[mode] || mode
)
if (mode === 'hover') {
return isTouchDevice() ? 'click' : 'mouseenter focus'
Copy link
Contributor Author

@AlexAndBear AlexAndBear Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add support for mobile devices !

@AlexAndBear AlexAndBear marked this pull request as ready for review June 12, 2025 10:02
@AlexAndBear AlexAndBear merged commit 453e754 into main Jun 12, 2025
18 checks passed
@AlexAndBear AlexAndBear deleted the issues/773 branch June 12, 2025 12:04
@openclouders openclouders mentioned this pull request Jun 11, 2025
Merged
1 task
openclouders pushed a commit that referenced this pull request Jun 12, 2025
@AlexAndBear
feat: add open with context menu item (#820)
68a43ec
@github-project-automation github-project-automation bot moved this to Qualification in OpenCloud Team Board Jun 13, 2025
@ScharfViktor ScharfViktor moved this from Qualification to Needs Tests in OpenCloud Team Board Jun 13, 2025
@ScharfViktor ScharfViktor mentioned this pull request Jun 17, 2025
Merged
@ScharfViktor ScharfViktor moved this from Needs Tests to Done in OpenCloud Team Board Jun 17, 2025
This was referenced Jun 20, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

No one assigned

Labels

Type:Feature-Request

Projects

OpenCloud Team Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexAndBear @JammingBen