Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

related #820

openning file with context menu.

image

Copilot AI review requested due to automatic review settings June 17, 2025 12:52
@ScharfViktor ScharfViktor requested a review from AlexAndBear June 17, 2025 12:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for opening files via the context menu in E2E tests.

  • Introduces a new openFileViaContextMenu method on the Resource page object
  • Implements the underlying context-menu interaction in actions.ts
  • Adds a Cucumber step and feature to drive the context-menu file open flow

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
tests/e2e/support/objects/app-files/resource/index.ts Added openFileViaContextMenu wrapper on Resource
tests/e2e/support/objects/app-files/resource/actions.ts Defined openFileViaContextMenu action and CSS selector
tests/e2e/cucumber/steps/ui/resources.ts Added step definition for opening via context menu
tests/e2e/cucumber/features/file-action/openFile.feature New feature scenario for file open via context menu
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

tests/e2e/support/objects/app-files/resource/index.ts:417

  • [nitpick] The fileViewer parameter is currently a plain string; consider typing it as a union of allowed viewers (e.g., collabora | 'text-editor' | 'preview') to catch invalid values earlier.
  async openFileViaContextMenu(resource: string, fileViewer: string): Promise<void> {

Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you <3

@ScharfViktor ScharfViktor force-pushed the openFileUsingContextMenu branch from 9dc9908 to 9fcebb9 Compare June 17, 2025 12:58
@ScharfViktor ScharfViktor force-pushed the openFileUsingContextMenu branch from 9fcebb9 to 1845ea7 Compare June 17, 2025 13:19
@ScharfViktor ScharfViktor merged commit f67d1cd into main Jun 17, 2025
18 checks passed
@ScharfViktor ScharfViktor deleted the openFileUsingContextMenu branch June 17, 2025 14:18
@openclouders openclouders mentioned this pull request Jun 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants