setup opencloud-keycloak-ldap setup. fix test after changing space template image #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the test failures resulting from changes to the space template image by updating the expected footer text in the pagination feature and aligning the environment commit ID.
- Updated expected footer text in the pagination feature to reflect new file size values.
- Updated the commit ID in the pipeline environment configuration to use the new image version.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/e2e/cucumber/features/user-settings/pagination.feature | Modified the expected footer text to match the updated image size details. |
| .woodpecker.env | Updated the OPENCLOUD_COMMITID to reference the new commit corresponding to the updated image. |
Comments suppressed due to low confidence (2)
tests/e2e/cucumber/features/user-settings/pagination.feature:54
- Verify that the updated footer text reflects the intended new file size and consider if a dynamic approach could reduce potential future maintenance of hard-coded values.
And "Alice" should see the text "112 items with 12 kB in total (56 files, 56 folders)" at the footer of the page
.woodpecker.env:2
- Ensure the updated commit ID aligns with the intended release and that corresponding tests and pipeline configurations are updated accordingly.
OPENCLOUD_COMMITID=e62ff11a0ea114c3bd1aea42a704e683031a67a8
AlexAndBear
approved these changes
Jun 24, 2025
AlexAndBear
approved these changes
Jun 24, 2025
ScharfViktor
changed the title
ScharfViktor
force-pushed
the
fixTestAfterChangingSpaceTemplateImage
branch
from
a796b3e to
418234a
Compare
ScharfViktor
changed the title
ScharfViktor
force-pushed
the
fixTestAfterChangingSpaceTemplateImage
branch
3 times, most recently
from
035e19a to
f5540ff
Compare
ScharfViktor
changed the title
setup keykloak with ldap
ScharfViktor
force-pushed
the
fixTestAfterChangingSpaceTemplateImage
branch
from
cd2d905 to
f6a9ac9
Compare
ScharfViktor
force-pushed
the
fixTestAfterChangingSpaceTemplateImage
branch
from
f6a9ac9 to
0fdffbb
Compare
rhafer
requested changes
Jun 27, 2025
rhafer
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use Keycloak as IdP, and users are created there — they are stored in LDAP.
There are a couple of tests that currently create users or groups via the Graph API. I plan to rewrite those in the next PR. In my opinion, tests should not create users or groups through the Graph API — instead, we should rely on Keycloak api for that