fix: add missing quotes to modal titles #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes quote marks used in modal titles across the application by replacing straight double quotes (") with angle quotes (»«) for consistency. The changes focus on user-facing messages in modal dialogs and notifications.
Key Changes:
- Updates quote formatting in space rename modal titles to use angle quotes with proper i18n interpolation
- Standardizes success and error message titles in SaveAs modal to use consistent angle quote formatting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| useSpaceActionsRename.ts | Updates rename space modal title to use angle quotes and proper i18n interpolation pattern |
| SaveAsModal.vue | Standardizes quote marks in both success and error message titles to use angle quotes |
tammi-23
approved these changes
Jul 18, 2025
Contributor
tammi-23
left a comment
tammi-23
left a comment
There was a problem hiding this comment.
👍 Reviewed and tested. Looks very good.
github-project-automation
bot
moved this from Qualification
to Done
in OpenCloud Team Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes