Skip to content

fix: add missing quotes to modal titles #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tammi-23 merged 4 commits into from
Jul 18, 2025
Merged

fix: add missing quotes to modal titles #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76c5cb2
fix: add missing quotes to modal titles
AlexAndBear Jul 18, 2025
08449a8
fix more occurences
AlexAndBear Jul 18, 2025
730483a
fix more occurences
AlexAndBear Jul 18, 2025
a973cd6
fix unit tests
AlexAndBear Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/web-pkg/src/components/Modals/SaveAsModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,13 @@ export default defineComponent({
try {
const resource = await saveFile({ destinationFolder, fileName, space })
showMessage({
title: $gettext('"%{fileName}" was saved successfully', { fileName: resource.name })
title: $gettext('»%{fileName}« was saved successfully', { fileName: resource.name })
})
openFile({ resource, space, locationQuery })
} catch (e) {
console.error(e)
showErrorMessage({
title: $gettext('Unable to save "%{fileName}"', { fileName }),
title: $gettext('Unable to save »%{fileName}«', { fileName }),
errors: [e]
})
console.error(e)
Expand Down
2 changes: 1 addition & 1 deletion packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export const useFileActionsCreateNewFile = ({ space }: { space?: Ref<SpaceResour
resourcesStore.upsertResource(resource)

showMessage({
title: $gettext('"%{fileName}" was created successfully', { fileName: resource.name })
title: $gettext('»%{fileName}« was created successfully', { fileName: resource.name })
})

if (unref(isEmbedModeEnabled)) {
Expand Down
2 changes: 1 addition & 1 deletion packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFolder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const useFileActionsCreateNewFolder = ({ space }: { space?: Ref<SpaceReso

resourcesStore.upsertResource(resource)

showMessage({ title: $gettext('"%{folderName}" was created successfully', { folderName }) })
showMessage({ title: $gettext('»%{folderName}« was created successfully', { folderName }) })

await nextTick()
scrollToResource(resource.id, { forceScroll: true, topbarElement: 'files-app-bar' })
Expand Down
2 changes: 1 addition & 1 deletion packages/web-pkg/src/composables/actions/spaces/useSpaceActionsRename.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const useSpaceActionsRename = () => {
}

dispatchModal({
title: $gettext('Rename space') + ' ' + resources[0].name,
title: $gettext('Rename space »%{name}«', { name: resources[0].name }),
confirmText: $gettext('Rename'),
hasInput: true,
inputLabel: $gettext('Space name'),
Expand Down
2 changes: 1 addition & 1 deletion packages/web-pkg/tests/unit/composables/actions/files/useFileActionsCreateNewFolder.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('useFileActionsCreateNewFolder', () => {
expect(upsertResource).toHaveBeenCalled()

const { showMessage } = useMessages()
expect(showMessage).toHaveBeenCalledWith({ title: '"myfolder" was created successfully' })
expect(showMessage).toHaveBeenCalledWith({ title: '»myfolder« was created successfully' })

// expect scrolltoresource to have been called
}
Expand Down