Skip to content

mini update 2: new table of contents#159

Merged
vbatts merged 4 commits intoopencontainers:reorgfrom
bloodorangeio:mini-update-2
Jun 29, 2020
Merged

mini update 2: new table of contents#159
vbatts merged 4 commits intoopencontainers:reorgfrom
bloodorangeio:mini-update-2

Conversation

@jdolitsky
Copy link
Copy Markdown
Contributor

This is a new table of contents for the spec, designed to
add simplicity and organization.

Existing content will later be moved into one of these sections,
or removed entirely if considered superfluous.


This PR is built on top of #158, so the diff is misleading. Please see the following for a true diff: bloodorangeio/distribution-spec@mini-update-1...bloodorangeio:mini-update-2

It seemed like a good idea at first to reorganize things
in a giant HTML comment, but it appears a failed strategy.

Instead, going to piecemeal changes into spec.md itself,
on the "reorg" branch. Then when everything ready, we can
make a big PR from "reorg" onto "master".

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
This is a new table of contents for the spec, designed to
add simplicity and organization.

Existing content will later be moved into one of these sections,
or removed entirely if considered superfluous.

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Comment thread spec.md
Comment thread spec.md Outdated
…nto HEAD

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
@jdolitsky
Copy link
Copy Markdown
Contributor Author

@rchincha modified based on your suggestions, please take a look when you have a min

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
old toc was simply derived from the contents.. we can revisit this after the content lands ...

@mikebrow
Copy link
Copy Markdown
Member

before merging this one do we want to make a copy of spec.md over to spec-new.md? or copy spec.md to spec-v.0.1.md Just thinking out-loud.

@jdolitsky
Copy link
Copy Markdown
Contributor Author

@mikebrow please see #160 (comment)

Notice the target branch for this PR (reorg vs. master)

@mikebrow
Copy link
Copy Markdown
Member

@mikebrow please see #160 (comment)

Notice the target branch for this PR (reorg vs. master)

didn't notice that before thx.

Copy link
Copy Markdown
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
besides the indentation?

Comment thread spec.md
- [PATCH Blob Upload](#patch-blob-upload)
- [PUT Blob Upload](#put-blob-upload)
- [DELETE Blob Upload](#delete-blob-upload)
- [Introduction](#introduction)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the indentation messed up?

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbatts vbatts merged commit 5d0af1c into opencontainers:reorg Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants